click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naoki Takezoe (Commented) (JIRA)" <>
Subject [jira] [Commented] (CLK-778) EmailField Data Validation Is Insufficient
Date Thu, 05 Apr 2012 17:16:25 GMT


Naoki Takezoe commented on CLK-778:

> if valid email addresses are not validate which would break backward compatibility? 

Valid email address would be also valid in the new validation rule.
So, In fact, I think this change would not make any effect to existing applications.
> EmailField Data Validation Is Insufficient
> ------------------------------------------
>                 Key: CLK-778
>                 URL:
>             Project: Click
>          Issue Type: Bug
>          Components: extras
>            Reporter: Clint Lawrence
>            Assignee: Naoki Takezoe
> In the Click Extras project, the current EmailField validation does not sufficiently
limit user input to the format of an email address.  As an example, I loaded the Avoka examples
site and was able to successfully submit the following as an email address in the Extra Form
Controls page:
> For my own use I have extended EmailField with the following additional validation logic:
>     private static final Pattern EMAIL_ADDRESS_REGEX_PATTERN = Pattern.compile("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,4}$",
>     ...
>     @Override
>     public void validate() {
>         super.validate();
>         if (EMAIL_ADDRESS_REGEX_PATTERN.matcher(StringUtils.trimToEmpty(this.value)).matches())
>         {
>             this.setErrorMessage("email-format-error");
>         }
>     }

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message