Return-Path: 
 <dev-return-2731-apmail-click-dev-archive=click.apache.org@click.apache.org>
Delivered-To: apmail-click-dev-archive@www.apache.org
Received: (qmail 55287 invoked from network); 22 Dec 2010 12:47:27 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 22 Dec 2010 12:47:27 -0000
Received: (qmail 11463 invoked by uid 500); 22 Dec 2010 12:47:27 -0000
Delivered-To: apmail-click-dev-archive@click.apache.org
Received: (qmail 11401 invoked by uid 500); 22 Dec 2010 12:47:24 -0000
Mailing-List: contact dev-help@click.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@click.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@click.apache.org>
List-Post: <mailto:dev@click.apache.org>
List-Id: <dev.click.apache.org>
Reply-To: dev@click.apache.org
Delivered-To: mailing list dev@click.apache.org
Received: (qmail 11394 invoked by uid 99); 22 Dec 2010 12:47:23 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Dec 2010 12:47:23 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Dec 2010 12:47:22 +0000
Received: from thor (localhost [127.0.0.1])
	by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBMCl1dH012845
	for <dev@click.apache.org>; Wed, 22 Dec 2010 12:47:01 GMT
Message-ID: <22760336.266441293022021355.JavaMail.jira@thor>
Date: Wed, 22 Dec 2010 07:47:01 -0500 (EST)
From: "Bob Schellink (JIRA)" <jira@apache.org>
To: dev@click.apache.org
Subject: [jira] Commented: (CLK-735) TabbedForm does not work with
 JavaScript validation
In-Reply-To: <21309164.125311291627210995.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CLK-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974174#action_12974174 ] 

Bob Schellink commented on CLK-735:
-----------------------------------

Nice patches Tomasz, very nice. I'll start integrating them soon. The #macro is a good idea to cleanup some of the repetitive markup in TabbedForm.htm.

Couple of nights ago I worked on a JS version for finding the parent sheet. I'll paste it below for reference. Looking at your patch we could change it slightly to use the following function to lookup the tab instead of passing the field names array:

  onShowTab(Click.getTabSheetNumber(' + fieldId + '))

Click.getTabSheetNumber=function(id) {
    var node=document.getElementById(id);
    if(!node) return 1;
    var parent = node.parentNode;
    while(parent && !Click.isTabSheet(parent)) {
        parent = parent.parentNode;
    }
    if (parent) return parent.getAttribute("id").substr(10);
    return 1;
}

Click.isTabSheet=function(node) {
    if(!node) return false;
    var id=node.getAttribute('id');
    if(id){
        if(id.indexOf('tab-sheet-')>=0) return true;
    }
    return false;
}

Anyway, something to ponder a bit.

Kind regards

Bob

> TabbedForm does not work with JavaScript validation
> ---------------------------------------------------
>
>                 Key: CLK-735
>                 URL: https://issues.apache.org/jira/browse/CLK-735
>             Project: Click
>          Issue Type: Bug
>          Components: extras
>    Affects Versions: 2.3.0-M1
>            Reporter: Bob Schellink
>            Priority: Minor
>             Fix For: 2.3.0-RC1
>
>         Attachments: control_js.patch, tabbed-form-demo_htm.patch, TabbedForm_htm.patch, TabbedForm_java.patch, TabbedFormDemo_java.patch
>
>
> Reported by Tomasz Bandura on the mailing list:
> http://click.markmail.org/thread/5gimf2vn2y5yozzy
> The TabbedForm.htm should check if $form.isJavaScriptValidation is on and render the html markup:
> <tr style="display:none" id="$form.getId()-errorsTr">
>   <td width='100%' align="$form.getErrorsAlign()">
>     <div class="errors" id="$form.getId()-errorsDiv"></div>
>   </td>
> </tr>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.