Return-Path: Delivered-To: apmail-click-dev-archive@www.apache.org Received: (qmail 18584 invoked from network); 23 Dec 2010 21:44:10 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Dec 2010 21:44:10 -0000 Received: (qmail 75363 invoked by uid 500); 23 Dec 2010 21:44:10 -0000 Delivered-To: apmail-click-dev-archive@click.apache.org Received: (qmail 75052 invoked by uid 500); 23 Dec 2010 21:44:10 -0000 Mailing-List: contact dev-help@click.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@click.apache.org Delivered-To: mailing list dev@click.apache.org Received: (qmail 75038 invoked by uid 99); 23 Dec 2010 21:44:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Dec 2010 21:44:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Dec 2010 21:44:07 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBNLhjSG018603 for ; Thu, 23 Dec 2010 21:43:46 GMT Message-ID: <15835038.4091293140625711.JavaMail.jira@thor> Date: Thu, 23 Dec 2010 16:43:45 -0500 (EST) From: "Bob Schellink (JIRA)" To: dev@click.apache.org Subject: [jira] Created: (CLK-743) Deprecate TrreNode constructor which accepts parent node MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Deprecate TrreNode constructor which accepts parent node -------------------------------------------------------- Key: CLK-743 URL: https://issues.apache.org/jira/browse/CLK-743 Project: Click Issue Type: Improvement Components: extras Affects Versions: 2.3.0-M1 Reporter: Bob Schellink Assignee: Bob Schellink Fix For: 2.3.0-RC1 TreeNode has constructors that accepts a parent node to which the new node is added to. This leads to the following code: new TrreNode("node1", parent); a little confusing because the newly created node isn't assigned and looks unused. By using one of the alternative consturctors we get this: TreeNode child = new TrreNode("node1"); parent.add(child); Now the code is clear as to what is happening. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.