click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Created: (CLK-743) Deprecate TrreNode constructor which accepts parent node
Date Thu, 23 Dec 2010 21:43:45 GMT
Deprecate TrreNode constructor which accepts parent node
--------------------------------------------------------

                 Key: CLK-743
                 URL: https://issues.apache.org/jira/browse/CLK-743
             Project: Click
          Issue Type: Improvement
          Components: extras
    Affects Versions: 2.3.0-M1
            Reporter: Bob Schellink
            Assignee: Bob Schellink
             Fix For: 2.3.0-RC1


TreeNode has constructors that accepts a parent node to which the new node is added to. This
leads to the following code:

  new TrreNode("node1", parent);

a little confusing because the newly created node isn't assigned and looks unused.

By using one of the alternative consturctors we get this:

  TreeNode child =  new TrreNode("node1");
  parent.add(child);

Now the code is clear as to what is happening.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message