click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (CLK-241) Table Headers use incorrect title attribute (table-last-title) when sortable=true
Date Sat, 23 Oct 2010 05:17:19 GMT

     [ https://issues.apache.org/jira/browse/CLK-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bob Schellink resolved CLK-241.
-------------------------------

    Resolution: Fixed
      Assignee: Bob Schellink  (was: Malcolm Edgar)

fixed

> Table Headers use incorrect title attribute (table-last-title) when sortable=true
> ---------------------------------------------------------------------------------
>
>                 Key: CLK-241
>                 URL: https://issues.apache.org/jira/browse/CLK-241
>             Project: Click
>          Issue Type: Bug
>          Components: core
>         Environment: Click 1.4RC1
>            Reporter: Patrick Talbot
>            Assignee: Bob Schellink
>            Priority: Minor
>             Fix For: 2.3.0-M1
>
>         Attachments: Column.java.patch
>
>
> In the renderTableHeader() method of the Column class, the actionLink is retrieved from
getTable().getControlLink().
> This method sends back the ActionLink used for paging, but...
> The problem is that the title of this ActionLinks is already set to getMessage("table-last-title")
in the renderPagingControls() method of the Table class if the banner position is TOP or BOTH,
and it is not set again in the renderTableHeader() method.
> Proposed solution : at least set the title of the retrieved ActionLink to somehting meaningful
in the renderTableHeader() method, like controlLink.setAttribute("title", getMessage("table-sort-links")),
where the entry would resolve to "Sort by" in the click-control.properties file ("TriƩ par"
in French).
> Easy to fix for the 1.4 release, I think.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message