Mailing-List: contact dev-help@click.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@click.apache.org
Message-ID: <4243166.159931278015711188.JavaMail.jira@thor>
Date: Thu, 1 Jul 2010 16:21:51 -0400 (EDT)
From: "Finn Bock (JIRA)" <jira@apache.org>
To: dev@click.apache.org
Subject: [jira] Updated: (CLK-661) Add Java based configuration
In-Reply-To: <30163817.21741271469864852.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CLK-661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Finn Bock updated CLK-661:
--------------------------

    Attachment: abstract-config-service.patch

I've updated the patch with an attempt to help Jahid's requirements by making the loadXXX() methods public. To get the feature of loading from both click.xml and annotations, you will have to subclass XmlConfigService. The patch is unfinished with regards to comments and methods location in the sourcefiles.

I've tried to move code from XmlConfigService to AbstractConfigService, f.ex deploy and automap code, but the result is too much of a mess.

The main classes can be viewed here:

http://people.apache.org/~bckfnn/AbstractConfigService.java.txt
http://people.apache.org/~bckfnn/XmlConfigService.java.txt


> Add Java based configuration
> ----------------------------
>
>                 Key: CLK-661
>                 URL: https://issues.apache.org/jira/browse/CLK-661
>             Project: Click
>          Issue Type: Improvement
>            Reporter: Bob Schellink
>            Assignee: Finn Bock
>             Fix For: 2.3.0-M1
>
>         Attachments: abstract-config-service.patch, defaultconfigservice.patch
>
>
> click.xml has grown over the years especially since we introduced the service based architecture. Some of the problems with xml based configurations is:
> - no compile time checking
> - no JavaDoc help in IDE
> I propose we add a new DefaultConfigService class that is Java based which XmlConfigService extends from.
> Its advantages is the polar opposite of xml disadvantage:
> - compile time checking
> - JavaDoc help in IDE
> - More powerful configuration options, e.g. its possible to configure FileUpload in ways not exposed by xml config. Also possible to create more powerful algorithms e.g. which templates to include/exclude.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.