Return-Path: Delivered-To: apmail-click-dev-archive@www.apache.org Received: (qmail 83485 invoked from network); 21 Jun 2010 08:50:25 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 21 Jun 2010 08:50:25 -0000 Received: (qmail 70548 invoked by uid 500); 21 Jun 2010 08:50:25 -0000 Delivered-To: apmail-click-dev-archive@click.apache.org Received: (qmail 70484 invoked by uid 500); 21 Jun 2010 08:50:23 -0000 Mailing-List: contact dev-help@click.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@click.apache.org Delivered-To: mailing list dev@click.apache.org Received: (qmail 69901 invoked by uid 99); 21 Jun 2010 08:50:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 08:50:22 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sabob1@gmail.com designates 209.85.212.170 as permitted sender) Received: from [209.85.212.170] (HELO mail-px0-f170.google.com) (209.85.212.170) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jun 2010 08:50:13 +0000 Received: by pxi6 with SMTP id 6so1426657pxi.29 for ; Mon, 21 Jun 2010 01:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=tDn2ue0vtwa5e1kDfNMGP/vpY2xbealfgS1aB0k4m0k=; b=ctpfrZvsxL8DL8jxvO68CY3K/Ea1wjUeoFJ5NMPA2eyrLYPLZI2xq+ixLiMr7HsM0C Dbd+ERZGGAWwFJm+UyAA4z2k8YDB5iH94VW75WpTgLMFoThNKUSonpVlxR/IqOKjmbZd XSvaSWj9b2EnEkb395GwjWHJulHHIXFgtWDDo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=fod+MRhY8TIbm6GJ+9NrrT8Sj+DL66a2pf4upMyCx+mKEabLyeb+sSBuVWa5LqE36u tnRLOIWw0+RpXnqSVeWwWmXv3AGhiptT5GqrvGWL7zHMoVIqKNsrzahuVvCGtamZoIDz E2J5G4+W7cKD+aQk7lb9dr6HIjHK3uFcdjpSU= Received: by 10.140.55.16 with SMTP id d16mr3634111rva.26.1277110192162; Mon, 21 Jun 2010 01:49:52 -0700 (PDT) Received: from [10.1.1.3] (124-170-0-85.dyn.iinet.net.au [124.170.0.85]) by mx.google.com with ESMTPS id q10sm2121776rvp.20.2010.06.21.01.49.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 21 Jun 2010 01:49:51 -0700 (PDT) Message-ID: <4C1F27AC.2010700@gmail.com> Date: Mon, 21 Jun 2010 18:49:48 +1000 From: Bob Schellink User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5 MIME-Version: 1.0 To: dev@click.apache.org Subject: Re: svn commit: r956086 - in /click/trunk/click/framework/src/org/apache/click/util: MessagesMap.java SessionMap.java References: <20100618183712.9000D23889BB@eris.apache.org> <4C1CE0A2.9090303@gmail.com> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 21/06/2010 06:52, Finn Bock wrote: > No, it is ok. HashMap.Entry is defined the same way. As long as the > object is only used as a Map.Entry, not as a SessionMap.Entry > instance, then all is fine. I have added a test for this. Appreciate the tests you've been adding. I'm starting to feel guilty for not contributing more in this area. Kind regards Bob