Return-Path: Delivered-To: apmail-click-dev-archive@www.apache.org Received: (qmail 82941 invoked from network); 19 Jun 2010 15:22:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Jun 2010 15:22:44 -0000 Received: (qmail 85502 invoked by uid 500); 19 Jun 2010 15:22:44 -0000 Delivered-To: apmail-click-dev-archive@click.apache.org Received: (qmail 85465 invoked by uid 500); 19 Jun 2010 15:22:43 -0000 Mailing-List: contact dev-help@click.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@click.apache.org Delivered-To: mailing list dev@click.apache.org Received: (qmail 85458 invoked by uid 99); 19 Jun 2010 15:22:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jun 2010 15:22:43 +0000 X-ASF-Spam-Status: No, hits=2.1 required=10.0 tests=AWL,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sabob1@gmail.com designates 74.125.83.170 as permitted sender) Received: from [74.125.83.170] (HELO mail-pv0-f170.google.com) (74.125.83.170) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jun 2010 15:22:35 +0000 Received: by pvg7 with SMTP id 7so362701pvg.29 for ; Sat, 19 Jun 2010 08:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=4BMZ0zMQbT3oJYveifpV0+XPfTBgTFEGBAH0Fx/oaXE=; b=hl9y032QB9qYxle6FXuMYyVPIARVouvhbTWkzaisR8LGgODqyKsThyEt9RL3I1IF9x ETL/8crJYf6DY8YnMjl2IO5Ze7Q56n52C144+uFkkdn5aXiKfXaQkxMKskacuIJ39dnK SRgUCuGv+rbkjGS3JfzSSv41s2ToWfUMY65Yg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=cAGjlQFZA4GFSvhg8iaI71JInnoXBwYNXr237SxllE2TQrp6vGzf4Wx/J17T1Suaoj 32EdHBweePsAwpV0oGmIm4rOkDdiMulEo2MK/95sfbQPnFp+w3/RNo43/lZQxzvCnxA8 H1j0t59ynMo2Z9U5N5X25jurKh+LTkci20GA8= Received: by 10.114.186.35 with SMTP id j35mr2074456waf.13.1276960935275; Sat, 19 Jun 2010 08:22:15 -0700 (PDT) Received: from [10.1.1.3] (124-170-34-139.dyn.iinet.net.au [124.170.34.139]) by mx.google.com with ESMTPS id r20sm123917206wam.5.2010.06.19.08.22.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 19 Jun 2010 08:22:14 -0700 (PDT) Message-ID: <4C1CE0A2.9090303@gmail.com> Date: Sun, 20 Jun 2010 01:22:10 +1000 From: Bob Schellink User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: dev@click.apache.org Subject: Re: svn commit: r956086 - in /click/trunk/click/framework/src/org/apache/click/util: MessagesMap.java SessionMap.java References: <20100618183712.9000D23889BB@eris.apache.org> In-Reply-To: <20100618183712.9000D23889BB@eris.apache.org> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/06/2010 04:37, bckfnn@apache.org wrote: > also fix a wrong values in SessionMap.entrySet() Seems SessionMap#entrySet should have been Map#values? Guess we can move that code under #values instead of throwing exception. I think the nested Entry class will give issues inside Velocity since it's not public. Can you confirm? regards Bob