click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Malcolm Edgar <malcolm.ed...@gmail.com>
Subject Re: Removing OgnlOps, ConcurrentReaderHashMap and WebappLoader
Date Thu, 17 Jun 2010 10:27:00 GMT
On Thu, Jun 17, 2010 at 7:54 PM, Adrian A. <a.adrian.tech@gmail.com> wrote:
>> I don't think upgrading is an option as
>> Ognl has dependencies on Javaassist
>
> Since OGNL 2.7, it looks like this dependency was introduced.
> I'll ask to see if it's possible remove that dependency.
>
>> and the project
>> development is quite obscure.
>
> I guess this is due to  the move to OpenSymphony. There was even a very
> recent 3.0 release, so people *are* working on the project.

I think Tapestry people are still working on this library.

>> 2. Drop ConcurrentReaderHashMap and use JDK5 ConcurrentHashMap. I know
>> there were concerns raised
>> wrt Spring but it isn't clear what those issues are. We can always revert
>> once we have more details.
>
> +1.
> I observed that upgrading Spring made those issues disappear.

OK I am willing to give this a try in a Release Candidate.

>> 3. We should rename WebappLoader as it can have the same issue as #1 if
>> Velocity Tools is included
>> in a Click project.
>
> Couldn't this functionality be included simply in Velocity Core?
> It looks that many web frameworks/projects are using it, and some do what
> Click does, other simply include VelocityTools JAR
> - but mostly just for this single class.
>
> Thank you,
>
> Adrian.
>

I think we should create a Click adaption/version of this class and
maintain it ourselves.

regards Malcolm Edgar

Mime
View raw message