click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Finn Bock <bck...@gmail.com>
Subject Re: svn commit: r956086 - in /click/trunk/click/framework/src/org/apache/click/util: MessagesMap.java SessionMap.java
Date Sun, 20 Jun 2010 20:52:16 GMT
2010/6/19 Bob Schellink
> On 19/06/2010 04:37, bckfnn@apache.org wrote:
>
> Seems SessionMap#entrySet should have been Map#values? Guess we can move that code under
#values
> instead of throwing exception.

Done.

> I think the nested Entry class will give issues inside Velocity since it's not public.
Can you confirm?

No, it is ok. HashMap.Entry is defined the same way. As long as the
object is only used as a Map.Entry, not as a SessionMap.Entry
instance, then all is fine. I have added a test for this.

regards,
Finn

Mime
View raw message