click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-650) Load DateField translations from JDK
Date Wed, 23 Jun 2010 23:23:50 GMT

    [ https://issues.apache.org/jira/browse/CLK-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881949#action_12881949
] 

Bob Schellink commented on CLK-650:
-----------------------------------

Thinking a about this today, one of the nice things about using Javascript to localize messages
is the translations are externalized into a JS file which gets download once and cached by
the browser. The proposed change will "inline" the translations, which becomes part of the
page markup. It could have performance impact in a scenario where a page uses a FormTable
with multiple datefield columns.

PS: a bit off topic but we really should try and find a replacement for the DateField Javascript
library. The JS popup library is now unmaintained and quite sluggish on IE. It is also tied
to the Prototype library which doesn't play nice with other libraries.

> Load DateField translations from JDK
> ------------------------------------
>
>                 Key: CLK-650
>                 URL: https://issues.apache.org/jira/browse/CLK-650
>             Project: Click
>          Issue Type: Improvement
>          Components: extras
>    Affects Versions: 2.2.0
>            Reporter: Bob Schellink
>            Assignee: Finn Bock
>            Priority: Minor
>         Attachments: datefield.patch, datefield_no_js.patch
>
>
> From CLK-624:
> Before we all go ahead and submit translations for month and day names (and abbreviations),
I think it would make more sense for DateField to generate these names from here:
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getWeekdays%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortWeekdays%28%29
> By creating the arrays from java's names we will AFAIK also instantly "support" all language
so that DateField.SUPPORTTED_LANGUAGES can be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message