click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Finn Bock (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CLK-650) Load DateField translations from JDK
Date Wed, 23 Jun 2010 13:17:52 GMT

     [ https://issues.apache.org/jira/browse/CLK-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Finn Bock updated CLK-650:
--------------------------

    Attachment: datefield_no_js.patch

I have updated the patch, but I'll like to check if it is ok before I commit because it changes
the current behaviour.

The language javascript files in extras/src/META-INF/resources/click/calendar/ have been removed.

The months and day names are created from java's DateFormatSymbols.

The week days shown in the popup header, is configured in the DateField_XX.properties, and
if not found there the getShortWeekdays() names are used. 

But this changes the default texts shown when we do not have a translation for the browser's
locale. If for instance the server is running on a polish Windows (we have a DateField_pl.properties
file with weekdays defined) and the browser locale is swedish (we do not have a DateField_sv.properties
file) then the week day heading is shown in english right now, but will be in polish with
this patch.

The patch makes popup headers behave consistent with error messages and other translated text.

For languages where we have a .properties file, but have no .js file, the patch will show
translated weekdays instead of english week day headings.



> Load DateField translations from JDK
> ------------------------------------
>
>                 Key: CLK-650
>                 URL: https://issues.apache.org/jira/browse/CLK-650
>             Project: Click
>          Issue Type: Improvement
>          Components: extras
>    Affects Versions: 2.2.0
>            Reporter: Bob Schellink
>            Assignee: Finn Bock
>            Priority: Minor
>         Attachments: datefield.patch, datefield_no_js.patch
>
>
> From CLK-624:
> Before we all go ahead and submit translations for month and day names (and abbreviations),
I think it would make more sense for DateField to generate these names from here:
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getWeekdays%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortWeekdays%28%29
> By creating the arrays from java's names we will AFAIK also instantly "support" all language
so that DateField.SUPPORTTED_LANGUAGES can be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message