click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Finn Bock (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-650) Load DateField translations from JDK
Date Thu, 24 Jun 2010 18:48:50 GMT

    [ https://issues.apache.org/jira/browse/CLK-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882279#action_12882279
] 

Finn Bock commented on CLK-650:
-------------------------------

I find it unreasonable to leave translations of day and month names to our users. Including
English, we have 10 translations. 5 of them (da, de, fi, fr & pt) are so incorrect that
the popup becomes useless.

Try picking a date in october with a german (de) locale and press Submit:

http://www.avoka.com/click-examples/form/extra-controls-form.htm

The field value is "20 Oct 2010" and mesages is:

Date Field ist ung├╝ltig. Das Datums-Format ist dd MMM yyyy

And for all the languages for which we do not have a .js file, we demand that users must type
in english month and day names! I would expect most uses of the DateField to use a number
only date format to avoid these issues.

I suppose we could generate cacheable javascript files with the correct day and month names
for each locale with a custom ant task during the build but I find that to be overkill.

Re. multiple date fields in formtables, then you are right, that is bug in my patch. The translations
should only be added to the page once. I'll upload a new patch.



> Load DateField translations from JDK
> ------------------------------------
>
>                 Key: CLK-650
>                 URL: https://issues.apache.org/jira/browse/CLK-650
>             Project: Click
>          Issue Type: Improvement
>          Components: extras
>    Affects Versions: 2.2.0
>            Reporter: Bob Schellink
>            Assignee: Finn Bock
>            Priority: Minor
>         Attachments: datefield.patch, datefield_no_js.patch
>
>
> From CLK-624:
> Before we all go ahead and submit translations for month and day names (and abbreviations),
I think it would make more sense for DateField to generate these names from here:
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortMonths%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getWeekdays%28%29
> http://java.sun.com/j2se/1.4.2/docs/api/java/text/DateFormatSymbols.html#getShortWeekdays%28%29
> By creating the arrays from java's names we will AFAIK also instantly "support" all language
so that DateField.SUPPORTTED_LANGUAGES can be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message