click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bob Schellink <sab...@gmail.com>
Subject Re: [jira] Closed: (CLK-671) Upgrade to Checkstyle 5.1
Date Wed, 26 May 2010 07:08:22 GMT
Oh. I don't think there is a need to run checkstyle on binaries though. Can we just remove
those
checks that require binary.

Regards

Bob


On 26/05/2010 16:12, Adrian A. wrote:
>> The changes seems reasonable. Running checkstyle on the codebase
>> throws the following error though.
>> Any ideas?
>>
>> [checkstyle]
>> C:\click-svn\framework\src\org\apache\click\service\TemplateService.java:0:
>> Got an
>> exception - java.lang.RuntimeException: Unable to get class
>> information for @throws tag
>> 'TemplateException'.
> This happens because the new check rules need the class binaries too (to
> be able to perform correctness checking), so checkstyle must be run only
> after the compilation of the sources.
> 
> Since our build.xml doesn't have individual "compile" tasks, one needs
> to run build-all first.
> I haven't changed:
> <target name="checkstyle" description="run checkstyle report on Java
> soruce">
> 
> to
> <target name="checkstyle" depends="build-all" description="run
> checkstyle report on Java soruce">
> 
> because of speed and output reasons (build-all generates lot of output
> on itself)
> 
> 


Mime
View raw message