click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Saputra <>
Subject Re: [jira] Created: (CLK-640) Add DataProvider for Table and Select controls
Date Wed, 10 Mar 2010 23:56:11 GMT
HI Malcolm,

Instead of DataProvider maybe we could call it DataModel since its purpose
basically to provide "model" for the UI components.
This model will provide abstraction for many data providers if necessary.

It will look something like this:

public interface DataModel{
     // public APIs for data access
    public Object getRawData();
    public void setRawData(Object data);
    public int getRowCount();

    // state management
    public boolean isActiveRow(); // return false if the model is stateless
or no active row exist in the current index
    public Object getRowIndex();
    public void setRowIndex(int index);
    public Object getRowData();

For DataModel to use with Java collection we could add a CollectionModel
class which wraps a Java Collection object:

public CollectionModel implements DataModel {
    private final Collection<? extends Object> rawData;

    public CollectionModel(java.util.Collection<? extends Object> data) {
        rawData = data;

    // implement DataModel APIs


The DataModel then could be extended to cover hierarchical model to support
tree or other complex components.

The idea is to wrap the raw collection/source data with Click model to
component developers dont have to deal wirh raw data directly.

Any thoughts?

- Henry

On Sat, Mar 6, 2010 at 1:43 AM, Malcolm Edgar (JIRA) <>wrote:

> Add DataProvider for Table and Select controls
> ----------------------------------------------
>                 Key: CLK-640
>                 URL:
>             Project: Click
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 2.1.0
>            Reporter: Malcolm Edgar
>             Fix For: 2.2.0
> One reoccurring problem we see with people using Click is the inappropriate
> use of the Page#onRender() method. Typically its used to set data into the
> Table control, but then people will often use this Page method to set data
> in other controls such as the FormTable or Select controls, which breaks
> their usage contract.
> What I would like to see is that data controls such as the Table, Select
> and FormTable are able to load the data when they need it, rather than
> having to rely on the developer injecting the data at the correct point in
> the pages life cycle.  This will provide an improve programming model where
> developers simply create their controls in the Page constructor or onInit()
> method, configure data providers when necessary, and write up control event
> handlers to the appropriate methods.
> The DataProvider interface would be very simple:
> public interface DataProvider {
>     public List getData();
> }
> Developers would then implement this interface when creating their
> controls:
> Table table = new Table();
> table.addColumn()
> ...
> table.setDataProvider(new DataProvider() {
>    public List getData() {
>         return customerDao.getCustomerList();
>    }
> });
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.

View raw message