click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Malcolm Edgar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-643) Form copy to object behaviour
Date Sun, 14 Mar 2010 07:25:27 GMT

    [ https://issues.apache.org/jira/browse/CLK-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845039#action_12845039
] 

Malcolm Edgar commented on CLK-643:
-----------------------------------

Yeah that is a good point. I think we should probably preserve the existing, but unintuitive
behaviour.

I think the Form object should have some additional properties which can be set to modify
the default copyToObject behaviour:

protected boolean noCopyFromDisabledFields;

protected boolean noCopyFromReadonlyFields;

These values would be inspected by the ContailerUtils methods to determine whether field values
should be copied.



> Form copy to object behaviour
> -----------------------------
>
>                 Key: CLK-643
>                 URL: https://issues.apache.org/jira/browse/CLK-643
>             Project: Click
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.1.0
>            Reporter: Malcolm Edgar
>            Assignee: Malcolm Edgar
>            Priority: Minor
>             Fix For: 2.2.0
>
>
> The Form#copyFormToObject() behaviour can be misleading in two respects.
> When a HTML forms field is disabled, its value is displayed in the browser window but
it is not editable and is disable. However when the user submits the form the field value
is not submitted even if it is populated. The Form#copyFormToObject() method will actually
nullify the target objects property value, as the disabled field has a null value.  This is
clearly not the expected behaviour.
> The other scenario which is problematic is with readonly fields. By default the Form#copyFormToObject()
method will write read only field value into the target objects properties. Sometimes this
is not the behaviour you are after, as type coercion behaviour cause errors. For example if
you are using a form which has some TextFields showin a date property as a readonly field,
when the form is submitted the string value will be set on the target objects property which
will cause type coercion issues, or may truncate data. The Form should have an option to not
write readonly field values when copying form field values to a target object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message