click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Schmidt (JIRA)" <>
Subject [jira] Commented: (CLK-543) SimpleLink control.
Date Wed, 03 Mar 2010 12:22:27 GMT


Joseph Schmidt commented on CLK-543:

> Of course, a much better approach would be to refactor e.g. AbstractLink to Link (and
make it non-abstract). Since it's abstract, 
> users don't use it directly, so most of them won't be affected. IMHO Click should be
as intuitive as possible, and in the case of a link, > there's nothing more intuitive than
"Link" :).
+1 for for changing AbstractLink to Link with the above improvement.
It could than also include the functionality of ExternalLink (and make it deprecated)

The less Abstract and fragmented Components the better.
This would be also background compatible, since users don't use AbstractLink directly, and
when compiling their code, they would see the warning that ExternalLink is deprecated.
New users on the other hand would find the component right away since it would be called "Link"

> SimpleLink control.
> -------------------
>                 Key: CLK-543
>                 URL:
>             Project: Click
>          Issue Type: New Feature
>          Components: extras
>            Reporter: Adrian A.
> There doesn't seem to be any "simple link" control in Click to be  able to point to an
arbitrary URL (internal but external too).
> There's now the ExternalLink but it's just too specific :( - extending it would conflict
with it's name (maybe a rename would be better).
> In many cases there's no distinction in the application between an internal an external
URL (e.g. because the external might be a subdomain).
> Another problem is that AbstractLink is can't be used directly for these simple cases
(being abstract).
> Basically a SimpleLink code would look like ExternalLink, but it would have this additional
snippet after L:106:
> <code>
>         String ctxPath = getContext().getRequest().getContextPath();
>         if(!getTargetPath().contains("://")) {
>             buffer.append(ctxPath);
>         }
> </code>
> This would allow to use only one control, and in the application logic, depending on
the target, to let the control itself render the required context path if needed.
> Thank you,
> A.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message