click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Finn Bock (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-629) ExternalLink unexpected href behavior
Date Wed, 17 Feb 2010 19:34:27 GMT

    [ https://issues.apache.org/jira/browse/CLK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834952#action_12834952
] 

Finn Bock commented on CLK-629:
-------------------------------

I wouldn't want any modification made to a targetPath like "http://www.google.com/". It should
be used as href exactly as is.

Regarding the missing constructor, I agree. The 2 most common pieces of information on a ExternalLink
is the href and the label so it would be nice to a constructor for that.

IMO the only surprising thing about ExternalLink is its location in the extras package.

> ExternalLink unexpected href behavior
> -------------------------------------
>
>                 Key: CLK-629
>                 URL: https://issues.apache.org/jira/browse/CLK-629
>             Project: Click
>          Issue Type: Bug
>          Components: extras
>    Affects Versions: 2.1.0
>            Reporter: Andrey Rybin
>            Priority: Minor
>
> All (most of) links in Click are "context-aware" ;-) i.e.   /link will be converted to
/servletcontextpath/link
> but 
> ExternalLink is different.
> It uses link (targetPath) "as is" without any modifications.
> It is unexpected behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message