click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Malcolm Edgar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-627) Field.getRequestValue optional value trim()
Date Tue, 16 Feb 2010 21:19:30 GMT

    [ https://issues.apache.org/jira/browse/CLK-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834476#action_12834476
] 

Malcolm Edgar commented on CLK-627:
-----------------------------------

Yeah I don't think this method should be trimming the value by default, but this is the current
behaviour so I dont think we can change this.

> Field.getRequestValue optional value trim()
> -------------------------------------------
>
>                 Key: CLK-627
>                 URL: https://issues.apache.org/jira/browse/CLK-627
>             Project: Click
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.1.0
>            Reporter: Andrey Rybin
>             Fix For: 2.2.0
>
>
> Field class contains method:
>     protected String getRequestValue() {
>         String value = getContext().getRequestParameter(getName());
>         if (value != null) {
>             return value.trim(); //<--- here
>         } else {    return "";     }
>     }
> Most of the time - trim is very nice feature (I like trim ;-).
> But sometimes I need field "as is" with all its spaces.
> Can You add option for _optional_ trim?
> It should be enabled by default (current behavior), but if somebody need spaces, he can
disable trim (for specific field).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message