click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "WarnerJan Veldhuis (JIRA)" <>
Subject [jira] Created: (CLK-626) FormTable does not gracefully handle NULL Fields
Date Tue, 16 Feb 2010 10:01:29 GMT
FormTable does not gracefully handle NULL Fields

                 Key: CLK-626
             Project: Click
          Issue Type: Improvement
          Components: extras
    Affects Versions: 2.1.0
            Reporter: WarnerJan Veldhuis

To be able to have columns in a FormTable that are "display only", ie no fields to edit, I
set the Field to null. FieldColumn is perfectly capable of handling NULLs for getField().
It will fallback to the super implementation when a Field is null, and render the data as
if it was a Column. 

FormTable however, does that only *partially*. Some parts are checked, some are not.

Line 283 of FormTable does a good job:
            if (fieldColumn.getField() != null) {

But further down the code, getField() is called and used directly. I would like to see it
checked for null. I have modified my local FormTable, and I can find no problems using it
like that.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message