click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Rybin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-612) Better user experience with DateField (and CalendarField).
Date Sat, 23 Jan 2010 17:30:17 GMT

    [ https://issues.apache.org/jira/browse/CLK-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804115#action_12804115
] 

Andrey Rybin commented on CLK-612:
----------------------------------

My final request is:

Please add 

//DateField.java

private Boolean lenientValidation = false; 


public Boolean isLenientValidation () {return lenientValidation;}

/**
* null - don't parse date. Only parent's validate (min,max len and required). Can be useful
for soft filters: 2008 ~ since 2008, 2009.02 till feb 2009.
* true - date will be parsed with lenient = true (less strict).
* false - strict date validation
*/

public void setLenientValidation (Boolean value) { lenientValidation = value;}
 
//@Override public void validate() { 

super.validate();

        if (isValid() && getValue().length() > 0 && lenientValidation !=
null) {
            SimpleDateFormat dateFormat = getDateFormat();
            dateFormat.setLenient(lenientValidation.booleanValue());
 



> Better user experience with DateField (and CalendarField).
> ----------------------------------------------------------
>
>                 Key: CLK-612
>                 URL: https://issues.apache.org/jira/browse/CLK-612
>             Project: Click
>          Issue Type: Improvement
>    Affects Versions: 2.1.0, 2.1.0 RC1
>            Reporter: Andrey Rybin
>
> Current DateField.validate() is too strict. 
> My suggestion is:
> Add two properties: 
> 1) String prop similarDelimiters:
> its format:   [oldChar1][newChar1] [oldChar2][newChar2].... if odd then ignore last char.
> 2) boolean prop  lenientValidation //def false
> 3) Modify  setValue (not tested):
>     public void setValue(String value) {
>         if (value != null && value.length() > 0) {
>            value = value.trim();
>      if (similarDelimiters != null && similarDelimiters.length > 0) {
>        for (int i=0; i<similarDelimiters.length-1; i+=2) {
>          value = value.replace(similarDelimiters.charAt(i), similarDelimiters.charAt(i+1));
>       }//f
>      }//i
>             try {
>                 Date parsedDate = getDateFormat().parse(value);
>                 // Cache date for subsequent retrievals
>                 date = new Date(parsedDate.getTime());
>             } catch (ParseException pe) {
>                 date = null;
>             }
>         } else {
>             date = null;
>         }
>         super.setValue(value);
>     }//setValue
> Because people in Russia use different characters  (ex:  /,-, .(dot)) as date delimiters,
not one.
> So I will set similarDelimiters to "-/\\/./" and pattern to dd/MM/yyyy - and it will
work.
> 4) Modify validate()
> dateFormat.setLenient(lenientValidation); 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message