click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Rybin (JIRA)" <j...@apache.org>
Subject [jira] Created: (CLK-606) common click core depends on Velocity
Date Fri, 15 Jan 2010 12:45:54 GMT
common click core depends on Velocity
-------------------------------------

                 Key: CLK-606
                 URL: https://issues.apache.org/jira/browse/CLK-606
             Project: Click
          Issue Type: Bug
          Components: core
    Affects Versions: 2.1.0 RC1, 2.0.1
         Environment: click-nodeps-2.1.0-RC1-incubating.jar , click-extras-2.1.0-RC1-incubating.jar,
ognl-2.6.9.jar, freemarket2.3.16.jar
            Reporter: Andrey Rybin


I use freemarker and dependencies in separate jars. 
I haven't 'velocity' in my classpath.
So I found bug: common click core depends on Velocity.

Namely:
org.apache.click.ClickServlet.java
org.apache.click.util.ErrorReport.java

They both depend on
org.apache.velocity.exception.ParseErrorException   (search:
instanceof ParseErrorException)
and require Velocity be present in classpath even if freemarker are used.

My workaround:
I made fake public class ParseErrorException extends Exception {}.

But you can make generic solution, for example:

TemplateService
+ boolean isParseErrorException (Exception e)
+ Map<String, Object> describeParseErrorException (Exception e)

or your own ClickTemplateException to wrap low level velocity/freemarker exceptions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message