click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (CLK-610) DateField formatPattern should not be static string, but static variable
Date Sun, 17 Jan 2010 12:41:54 GMT

     [ https://issues.apache.org/jira/browse/CLK-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bob Schellink resolved CLK-610.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0
         Assignee: Bob Schellink

Fixed in trunk.

> DateField formatPattern should not be static string, but static variable
> ------------------------------------------------------------------------
>
>                 Key: CLK-610
>                 URL: https://issues.apache.org/jira/browse/CLK-610
>             Project: Click
>          Issue Type: Improvement
>            Reporter: Andrey Rybin
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> DateField constructors contain this code:
>  super(...);
>   ...
>  setFormatPattern("dd MMM yyyy");
> (yes, same code 3 times ;-)
> I suggest to replace it with this:
> public static String defaultFormatPattern = "dd MMM yyyy";
>  super(...);
>   ...
>  setFormatPattern(defaultFormatPattern);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message