click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "WarnerJan Veldhuis (JIRA)" <>
Subject [jira] Created: (CLK-601) TextField sets size when not appropriate
Date Wed, 30 Dec 2009 13:33:29 GMT
TextField sets size when not appropriate

                 Key: CLK-601
             Project: Click
          Issue Type: Improvement
          Components: core
    Affects Versions: 2.1.0 RC1
            Reporter: WarnerJan Veldhuis
            Priority: Trivial

In the TextField class, the size attribute is *always* rendered regardless of the value of
size. Since the size-attribute should be optional for the input-tag, it should be conditional,
just as it is the case with maxLength and tabIndex. This would also mean that the default
of 20 should be dropped.

current code:
buffer.appendAttribute("size", getSize());

proposed code:
if ( getSize() > 0 ) {
   buffer.appendAttribute("size", getSize());

Since the HTML-spec says size is implied, it should only be added if there is any size.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message