click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian A. (JIRA)" <>
Subject [jira] Updated: (CLK-536) setRedirect() to support parameters too.
Date Mon, 18 May 2009 13:41:45 GMT


Adrian A. updated CLK-536:

    Attachment: setRedirect_with_params_and_javadocs.diff

This new patch contains some javadocs now.

I could also add 2 new methods: 
setRedirect(String path, String paramName, String paramValue)
setRedirect(Class page, String paramName, String paramValue)
for the cases where a *single* parameter is used.

Using setRedirect(DetailPage.class, new HashMap(){{put("customer", id);}}); 
looks a little bit complicated for newbies (if they want to have a concise usage), although
IDEs these days autocomplete it quickly and correctly.

> setRedirect() to support parameters too.
> ----------------------------------------
>                 Key: CLK-536
>                 URL:
>             Project: Click
>          Issue Type: New Feature
>            Reporter: Joseph Schmidt
>            Assignee: Malcolm Edgar
>         Attachments: setRedirect_with_params.diff, setRedirect_with_params_and_javadocs.diff
> Please extend the setRedirect() methods to support parameters too.
> Right now it is possible to use parameters only by manually creating the redirect location(and
using the String version of the method). This is however very error prone.
> Please extend the two existing methods:
> setRedirect(String location) and
> setRedirect(Class pageClass)
> with a "params" parameter, e.g.
> setRedirect(String location, Map params) and 
> setRedirect(Class pageClass, Map params
> to work for the very required case when the destination requires parameters.
> thanks,
> Joseph.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message