click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-551) Menu default rendering with class="selected" on current selection
Date Thu, 21 May 2009 15:18:45 GMT

    [ https://issues.apache.org/jira/browse/CLK-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711647#action_12711647
] 

Bob Schellink commented on CLK-551:
-----------------------------------

Hi Malcolm,

Are you saying that the class "selected" clashes with other defined styles?

I've been wonder if we shouldn't start namespacing our JavaScript and CSS to avoid this issue.

For example I've already started using the Click namespace for JavaScript. For CSS we could
prefix classes with 'clk_selected' or 'c_selected'.

In the Javadoc we could mention the CSS classes used by the control, similar to the way we
mention JavaScript and CSS imports.

bob

> Menu default rendering with class="selected" on current selection
> -----------------------------------------------------------------
>
>                 Key: CLK-551
>                 URL: https://issues.apache.org/jira/browse/CLK-551
>             Project: Click
>          Issue Type: Improvement
>          Components: extras
>    Affects Versions: 2.1.0
>            Reporter: Frederic Daoud
>            Assignee: Malcolm Edgar
>            Priority: Minor
>             Fix For: 2.1.0
>
>         Attachments: CLK-551.patch
>
>
> Menus can be rendered in many different ways of course, and it's up to the user to decide
how to do the rendering.
> However, the Menu class does include a default with its toString() method, which is to
render the Menu as an anchor link. When that default is sufficient for the user's purposes,
it would be nice if the currently selected menu (and parents) had a class="selected" added
to the a tag's attributes, making it trivial to highlight it with some CSS.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message