Return-Path: Delivered-To: apmail-incubator-click-dev-archive@minotaur.apache.org Received: (qmail 22220 invoked from network); 15 Apr 2009 19:49:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Apr 2009 19:49:37 -0000 Received: (qmail 96110 invoked by uid 500); 15 Apr 2009 19:49:37 -0000 Delivered-To: apmail-incubator-click-dev-archive@incubator.apache.org Received: (qmail 96069 invoked by uid 500); 15 Apr 2009 19:49:37 -0000 Mailing-List: contact click-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: click-dev@incubator.apache.org Delivered-To: mailing list click-dev@incubator.apache.org Received: (qmail 96059 invoked by uid 99); 15 Apr 2009 19:49:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 19:49:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 19:49:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E3A00234C003 for ; Wed, 15 Apr 2009 12:49:14 -0700 (PDT) Message-ID: <8635335.1239824954918.JavaMail.jira@brutus> Date: Wed, 15 Apr 2009 12:49:14 -0700 (PDT) From: "Bob Schellink (JIRA)" To: click-dev@incubator.apache.org Subject: [jira] Commented: (CLK-406) Menu improvements - plug-able role checking. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CLK-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699337#action_12699337 ] Bob Schellink commented on CLK-406: ----------------------------------- Hi Malcolm, Looks good to me. Couple of questions though: - The acronym "RBA" seems a bit out of place. What about DefaultAccessController or BasicAccessController? - Out of interest are there any use cases of AccessController outside of Menu at this point? bob > Menu improvements - plug-able role checking. > -------------------------------------------- > > Key: CLK-406 > URL: https://issues.apache.org/jira/browse/CLK-406 > Project: Click > Issue Type: Improvement > Components: extras > Reporter: Demetrios Kyriakis > > Please improve the Menu Control, by allowing the user to have a plug-able role cheking for the menu items. > Right now the Menu Control is using HttpRequest#isUserInRole(String role), but most webapplications > don't use this strategy for user/roles management, so this method returns false for all those cases :(. > This is very limiting, making the existing Menu Control useless for most user applications, thus forcing the users > to make their own menu controls (or the hack the original one). > Please allow to set a different method for this operation by the user (if no other is used, of course, the default one - mentioned above - would be used as before - so 100% backwards compatible). > Thank you, > Demetrios. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.