Return-Path: 
 <click-dev-return-610-apmail-incubator-click-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-click-dev-archive@minotaur.apache.org
Received: (qmail 5323 invoked from network); 18 Apr 2009 10:51:36 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 18 Apr 2009 10:51:36 -0000
Received: (qmail 2031 invoked by uid 500); 18 Apr 2009 10:51:35 -0000
Delivered-To: apmail-incubator-click-dev-archive@incubator.apache.org
Received: (qmail 1992 invoked by uid 500); 18 Apr 2009 10:51:35 -0000
Mailing-List: contact click-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:click-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:click-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:click-dev@incubator.apache.org>
List-Id: <click-dev.incubator.apache.org>
Reply-To: click-dev@incubator.apache.org
Delivered-To: mailing list click-dev@incubator.apache.org
Received: (qmail 1984 invoked by uid 99); 18 Apr 2009 10:51:35 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2009 10:51:35 +0000
X-ASF-Spam-Status: No, hits=-1999.6 required=10.0
	tests=ALL_TRUSTED,SUBJECT_FUZZY_TION
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2009 10:51:35 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id CDDA7234C004
	for <click-dev@incubator.apache.org>; Sat, 18 Apr 2009 03:51:14 -0700 (PDT)
Message-ID: <692832637.1240051874828.JavaMail.jira@brutus>
Date: Sat, 18 Apr 2009 03:51:14 -0700 (PDT)
From: "Joseph Schmidt (JIRA)" <jira@apache.org>
To: click-dev@incubator.apache.org
Subject: [jira] Commented: (CLK-520) Button should be rendered as "button"
In-Reply-To: <982683997.1239096913426.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700454#action_12700454 ] 

Joseph Schmidt commented on CLK-520:
------------------------------------

> > it's impossible to add an icon to it
> You can easily add an icon to input controls by using the CSS background property. 
Unfortunately this won't do the trick for most cases, because CSS (as of supported by most browsers today) allows only one background file, and this is already required for the margins and the 3D effect of elements.

This is why the Button (as <button>) was invented in first place.

I think Click should be not just background compatible, but *correct* too.
With the above IE fix it would be background compatible to a great degree. With a rendering option:
e.g. boolean renderAsInput = true (default), could be 100% background compatible), but not so "clean" like a simple move to <button> tag.

thanks,
Joseph.

> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading since with
> that type of tag, it's not possible to embed icons or span tags or something else(the "button" tag would normally allow) in the button to make it look better or what the requirements ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement (so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.