click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Malcolm Edgar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-508) Move isFormSubmission check to Field
Date Fri, 03 Apr 2009 11:22:13 GMT

    [ https://issues.apache.org/jira/browse/CLK-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695337#action_12695337
] 

Malcolm Edgar commented on CLK-508:
-----------------------------------

-1 

There are two reason's I am voting against this change:

#1 - I think this change will break the behaviour of existing applications, in non obvious
ways, particularly where people have subclassed forms and fields. I find the prospect of having
to upgrade existing applications to this scary. We introduced a lot of changes in the 1.5
release, which took a long time to get sorted and provide a reasonable upgrade path from 1.4.
 I don't think we should be subjecting people to this level of change again.

#2 - I think we are pushing out of Click's sweat, trying to solve the fringe cases and making
the framework more complex.

> Move isFormSubmission check to Field
> ------------------------------------
>
>                 Key: CLK-508
>                 URL: https://issues.apache.org/jira/browse/CLK-508
>             Project: Click
>          Issue Type: Improvement
>          Components: core, extras
>            Reporter: Bob Schellink
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> Currently Form determines whether its child controls should be processed based on whether
Form was submitted or not. This restriction works well for Fields, however problems arise
when adding components such as ActionLink, Tables and Trees which need to be processed even
when Form is not submitted. Ajax based Fields also has this problem and often need to be added
to the Page in order to be processed.
> This issue will try and address the problem by introducing a new Field method called
"canProcess". This method will return true if the Form is submitted or if its a Ajax request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message