[ https://issues.apache.org/jira/browse/CLK-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699337#action_12699337
]
Bob Schellink commented on CLK-406:
-----------------------------------
Hi Malcolm,
Looks good to me. Couple of questions though:
- The acronym "RBA" seems a bit out of place. What about DefaultAccessController or BasicAccessController?
- Out of interest are there any use cases of AccessController outside of Menu at this point?
bob
> Menu improvements - plug-able role checking.
> --------------------------------------------
>
> Key: CLK-406
> URL: https://issues.apache.org/jira/browse/CLK-406
> Project: Click
> Issue Type: Improvement
> Components: extras
> Reporter: Demetrios Kyriakis
>
> Please improve the Menu Control, by allowing the user to have a plug-able role cheking
for the menu items.
> Right now the Menu Control is using HttpRequest#isUserInRole(String role), but most webapplications
> don't use this strategy for user/roles management, so this method returns false for all
those cases :(.
> This is very limiting, making the existing Menu Control useless for most user applications,
thus forcing the users
> to make their own menu controls (or the hack the original one).
> Please allow to set a different method for this operation by the user (if no other is
used, of course, the default one - mentioned above - would be used as before - so 100% backwards
compatible).
> Thank you,
> Demetrios.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|