click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Schmidt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-520) Button should be rendered as "button"
Date Sat, 18 Apr 2009 10:45:14 GMT

    [ https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700452#action_12700452
] 

Joseph Schmidt commented on CLK-520:
------------------------------------

> We cant change the button submit at this stage it will break the appearance and behaviour
of too many applications. 
For most users it won't breake anything, considering the IE fix.  I believe the 80/20 rule
should apply and not force the majority to use hacks because of a minority that could use
the hack (they would have the old sources too).

> However we could look at adding a <button> element control to Click Extras. 
As a usability compromise, why not add it as rendering option than (for the base Button component),
to be able to propagate that <button> tag up to all existing Button descendents, and
not to be forced to rewrite them too.

thanks,
Joseph.

> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading
since with
> that type of tag, it's not possible to embed icons or span tags or something else(the
"button" tag would normally allow) in the button to make it look better or what the requirements
ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement
(so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls
of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message