click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Schellink (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-520) Button should be rendered as "button"
Date Tue, 07 Apr 2009 14:43:13 GMT

    [ https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696554#action_12696554
] 

Bob Schellink commented on CLK-520:
-----------------------------------

Just tested and noticed the following issues with "button" in IE6/7. (IE8 seems to have fixed
the issues but only for standards mode)

- IE will submit the button's inner html instead of its value.
- IE will submit the values of other buttons to the server as well so you cannot discern which
button was submitted. (limited to IE6 only)

I agree that button has much better rendering capabilities, however IE doesn't play well with
it.

Here is the test used:

<html>
    <body>
        <form target="" method="get">
            <button type="submit" name="one" value="oneValue">First Button Pressed</button>
            <button type="submit" name="two" value="twoValue">Second Button Pressed</button>
        </form>

         <form target="" method="get">
            <input type="submit" name="one" value="oneValue"/>
            <input type="submit" name="two" value="twoValue"/>
        </form>
    </body>
</html>

> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading
since with
> that type of tag, it's not possible to embed icons or span tags or something else(the
"button" tag would normally allow) in the button to make it look better or what the requirements
ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement
(so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls
of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message