click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Warner (JIRA)" <>
Subject [jira] Commented: (CLK-527) FormTable sort fields are not populated for render
Date Mon, 27 Apr 2009 02:05:30 GMT


Ben Warner commented on CLK-527:

Hey Bob,

Yes I did have issues with this. The setSortedColumn method on Table looks like this:

    public void setSortedColumn(String value) {
        sortedColumn = value;

Changing the sort column does not update the sorted value to false.

The render method calls sortRowList() before rendering the body rows:

    protected void sortRowList() {
        if (!isSorted() && StringUtils.isNotBlank(getSortedColumn())) {
            Column column = (Column) getColumns().get(getSortedColumn());
            Collections.sort(getRowList(), column.getComparator());

The first time this method gets called it will set the 'sorted' variable to true and no matter
how many times you change the sort column or direction this 'sorted' variable does not get
re-initialised. The second time we come into sortRowList() the list only gets sorted if the
isSorted() method returns false:

    public boolean isSorted() {
        return sorted;

So, if you change the sort column between when the table was first sorted and when it was
rendered, the new sort order will not be reflected in the table. There lies the problem.


> FormTable sort fields are not populated for render
> --------------------------------------------------
>                 Key: CLK-527
>                 URL:
>             Project: Click
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5
>            Reporter: Ben Warner
> On an instance of FormTable we have the capability to set the sorted column, sorted ascending,
and page number values. These methods are inherited from the Table class but no overridden
methods are provided in Form Table.
> When the form table is rendered there are hidden form fields defined which are intended
to store the values of these properties but the values of these hidden fields don't ever seem
to be set. These hidden fields get rendered in the startTag() method of the internal form...
>             buffer.append(getForm().startTag());
> Because these fields are not populated, the submit function is not aware of any sorting
that has been applied to the table and the values are often populated into the wrong underlying
objects if the default sorting of the table is not the same as the explicit sorting of the
> I've resolved this for my application by subclassing FormTable and overriding the 3 relevant
methods as follows:
>     public void setSortedColumn(String columnName) {
>         Field field = (Field)getForm().getFields().get(COLUMN);
>         if(field != null){
>             field.setValue(columnName);
>         }
>         setSorted(false);
>         super.setSortedColumn(columnName);
>     }
>     public void setSortedAscending(boolean ascending) {
>         Field field = (Field)getForm().getFields().get(ASCENDING);
>         if(field != null){
>             field.setValue("" + ascending);
>         }
>         setSorted(false);
>         super.setSortedAscending(ascending);
>     }
>     public void setPageNumber(int pageNumber) {
>         Field field = (Field)getForm().getFields().get(PAGE);
>         if(field != null){
>             field.setValue("" + pageNumber);
>         }
>         super.setPageNumber(pageNumber);
>     }
> These overridden methods should be in FormTable to resolve this bug. I have been working
with version 1.5 so it may already be resolved in a later version.
> Note also that I am calling setSorted(false) in the first 2 methods.
> BW.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message