click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Highway (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-508) Move isFormSubmission check to Field
Date Thu, 02 Apr 2009 14:07:13 GMT

    [ https://issues.apache.org/jira/browse/CLK-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695012#action_12695012
] 

Christopher Highway commented on CLK-508:
-----------------------------------------

I personally think that everything you put in a form should be part of that form, eg. return
with post, and not get.

for Actionlinks: 
This can be realised with a little javascript (http://www.javascript-coder.com/javascript-form/javascript-form-submit.phtml)
Question is if this should be the responsability of the user or click.

A possible solution:
- Create a FormActionLink class which automatically adds the necessary javascript to the page.
(optionally only allow formactionlinks to be added to a form)
- create a hiddenfield to keep information if/which actionlink was clicked.
(optionally provide functionality to create hidden field(s) for extra parameters added to
the actionlink)
- on return we need a check on the hidden field to see if/which actionlink was clicked.

for ajax it is also possible to use post, but this is less trivial and probably more a responsability
for the user

for complex get/post controls (I haven't looked at the code, so this is just a general observation):
if you move all the get's (opening nodes and so on) to ajax-calls, as these calls do not (need
to) destroy the form data, then at the end the form can still be submitted using a simple
submit.


> Move isFormSubmission check to Field
> ------------------------------------
>
>                 Key: CLK-508
>                 URL: https://issues.apache.org/jira/browse/CLK-508
>             Project: Click
>          Issue Type: Improvement
>          Components: core, extras
>            Reporter: Bob Schellink
>            Assignee: Bob Schellink
>             Fix For: 2.1.0
>
>
> Currently Form determines whether its child controls should be processed based on whether
Form was submitted or not. This restriction works well for Fields, however problems arise
when adding components such as ActionLink, Tables and Trees which need to be processed even
when Form is not submitted. Ajax based Fields also has this problem and often need to be added
to the Page in order to be processed.
> This issue will try and address the problem by introducing a new Field method called
"canProcess". This method will return true if the Form is submitted or if its a Ajax request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message