click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Schmidt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-520) Button should be rendered as "button"
Date Tue, 07 Apr 2009 13:48:12 GMT

    [ https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696529#action_12696529
] 

Joseph Schmidt commented on CLK-520:
------------------------------------

> Joseph, have you tested button with different browsers?
FF, IE, Opera, Chrome on Vista.

> If I recall "button" is quite problematic with IE6 / 7. 
I don't have an IE6 around, but in IE7 the button tag with button type, 
looks and behaves exactly like the input tag with button type (at least from the tests I did).

Of course, Malcolm is right: if someone did custom styling to an <input/> based button
- e.g. to be green, using a tag based CSS selector, e.g. 
input[type=button]{
            background-color:green;
}
 (not a class or id one) a new version of Click with a <button/> button would not look
the same - since that selector would not apply to <button> elements.



> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading
since with
> that type of tag, it's not possible to embed icons or span tags or something else(the
"button" tag would normally allow) in the button to make it look better or what the requirements
ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement
(so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls
of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message