click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Schmidt (JIRA)" <>
Subject [jira] Commented: (CLK-520) Button should be rendered as "button"
Date Tue, 07 Apr 2009 10:25:12 GMT


Joseph Schmidt commented on CLK-520:

This is nice (the wufoo code for those 3 'buttons'), but it's too much - the style there is
just too complicated (and it's also pixel based)

> I don't think this is a bug
I expected a "button" element by default, since this was it's name and HTML *has* a button
tag :).

> This could be handled by introducing a rendering option
Isn't this too complicated? 
I believe that by replacing the tag "input" of type "button" the tag "button" of type button"
everything should work as before (if backwards compatibility would be a problem).

> where people could specify the way it should be rendered and include img content support.
Most cases I saw, are just as simple as below:
<img align="left" src="assets/images/name.png"/><span>Name</span>
with the style:
button span {padding-left:1em; font-weight:bold;}
(for the space between icon and label)


> Button should be rendered as "button"
> -------------------------------------
>                 Key: CLK-520
>                 URL:
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading
since with
> that type of tag, it's not possible to embed icons or span tags or something else(the
"button" tag would normally allow) in the button to make it look better or what the requirements
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement
(so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls
of class Button would behave as before.
> thanks,
> Joseph.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message