click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Schmidt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CLK-520) Button should be rendered as "button"
Date Fri, 17 Apr 2009 15:12:15 GMT

    [ https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700202#action_12700202
] 

Joseph Schmidt commented on CLK-520:
------------------------------------

> - It will break existing applications styling 
It shouldn't if styling was applied correctly with theming, and not hardcoded (in this case
any rendering change could break it - and there were in the past a few changes in the click
rendering).

> - Button is a core control of Click and it won't work on IE without JavaScript hacks.
What if the site is suppose to work without JavaScript?
The page calling it does not require Javascript:
 http://ie-button-fix.googlecode.com/svn/trunk/ie-button-test.html
The included HTC (specific to IE) is specific to JS (but IE handles it differently I think),
however:
 - if the site is supposed to work without JavaScript than most other things in Click won't
work either (e.g. the actual ActionButton too)


> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is quite misleading
since with
> that type of tag, it's not possible to embed icons or span tags or something else(the
"button" tag would normally allow) in the button to make it look better or what the requirements
ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very common requirement
(so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so derived controls
of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message