click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Malcolm Edgar <malcolm.ed...@gmail.com>
Subject Re: performance improvement
Date Mon, 09 Mar 2009 00:50:36 GMT
Good work.   Can you back port this change?
regards Malcolm Edgar

On Mon, Mar 9, 2009 at 8:13 AM, Bob Schellink <sabob1@gmail.com> wrote:

> Done some performance testing today and noticed that when there is a large
> hierarchy of controls on page, performance degrade quite a bit.
>
> I've tracked down the problem to AbstractContainer#getHtmlImports which
> creates a large buffer for HTML imports. Each container in the hierarchy
> will create this buffer, whether its used or not, which is wasted memory and
> causes the performance degrade.
>
> I've checked in a change to create a buffer of size 0 which resolves the
> above issues. And since subclasses such as Form creates their own buffers
> this should not impact existing code.
>
> bob
>
>
>

Mime
View raw message