click-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian A. (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CLK-421) Move SourceViewer from examples to utils
Date Tue, 31 Mar 2009 17:52:51 GMT

     [ https://issues.apache.org/jira/browse/CLK-421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adrian A. updated CLK-421:
--------------------------

    Attachment: SourceViewerPanel.diff

I think a much better idea is to make a SourceViewerPanel control, that can be reused directly
as a component in any project.
In the attached patch I included one, plus a demo page of rendering border-template.htm (I
also added the menu item for it).

If this is OK, I could change SourcePage to use this Panel directly.

> Move SourceViewer from examples to utils
> ----------------------------------------
>
>                 Key: CLK-421
>                 URL: https://issues.apache.org/jira/browse/CLK-421
>             Project: Click
>          Issue Type: Improvement
>            Reporter: Demetrios Kyriakis
>            Priority: Minor
>         Attachments: SourceViewerPanel.diff
>
>
> Please move the SourceViewer utility class from click-examples to some util package inside
click because:
> - it is usable in more places than just click-examples, and users duplicate it all the
time, by copy and paste.
> - it could be used even in error reporting to display nice source code where errors appear.
> - even ClickClick has a duplicated class for SourceViewer
> - it would be much simpler to make other example webapplications moredeveloper friendly
if this
> class would be present in utils.
> - other concurrent frameworks don't have such an utility and display pure text :).
> Thank you,
> Demetrios.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message