click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r1054227 - in /click/trunk/click: documentation/docs/ framework/src/org/apache/click/control/
Date Sat, 01 Jan 2011 12:24:25 GMT
Author: sabob
Date: Sat Jan  1 12:24:25 2011
New Revision: 1054227

URL: http://svn.apache.org/viewvc?rev=1054227&view=rev
Log:
Fixed Control IDs to replace periods with underscores. CLK-747

Modified:
    click/trunk/click/documentation/docs/roadmap-changes.html
    click/trunk/click/documentation/docs/upgrade-path.html
    click/trunk/click/framework/src/org/apache/click/control/Field.java
    click/trunk/click/framework/src/org/apache/click/control/Panel.java
    click/trunk/click/framework/src/org/apache/click/control/Radio.java

Modified: click/trunk/click/documentation/docs/roadmap-changes.html
URL: http://svn.apache.org/viewvc/click/trunk/click/documentation/docs/roadmap-changes.html?rev=1054227&r1=1054226&r2=1054227&view=diff
==============================================================================
--- click/trunk/click/documentation/docs/roadmap-changes.html (original)
+++ click/trunk/click/documentation/docs/roadmap-changes.html Sat Jan  1 12:24:25 2011
@@ -272,6 +272,10 @@ Action support and light-weight stateful
               [<a target="_blank" href="https://issues.apache.org/jira/browse/CLK-695">CLK-695</a>].
           </li>
           <li class="change">
+              Fixed Control IDs to render underscores instead of periods
+              [<a target="_blank" href="https://issues.apache.org/jira/browse/CLK-747">CLK-747</a>].
+          </li>
+          <li class="change">
               Fixed escaping of control values and attributes to be XML friendly
               in order to support Ajax requests. Previously all HTML characters was escaped,
               now only the following characters are escaped: &lt;, &gt;, &quot;,
&#039;, &amp;

Modified: click/trunk/click/documentation/docs/upgrade-path.html
URL: http://svn.apache.org/viewvc/click/trunk/click/documentation/docs/upgrade-path.html?rev=1054227&r1=1054226&r2=1054227&view=diff
==============================================================================
--- click/trunk/click/documentation/docs/upgrade-path.html (original)
+++ click/trunk/click/documentation/docs/upgrade-path.html Sat Jan  1 12:24:25 2011
@@ -159,6 +159,11 @@ public void onInit() {
     } </pre>
       </li>
       <li class="change">
+        Control IDs now render underscores instead of periods. If you targeted
+        Controls through CSS or JavaScript where the ID had a period, you need
+        to change to underscores.
+      </li>
+      <li class="change">
         The DateField control now accepts month and day names spelled in the 
         locale of the browser or application (see 
         <a href="click-api/org/apache/click/Context.html#getLocale()">Context.getLocale()</a>).

Modified: click/trunk/click/framework/src/org/apache/click/control/Field.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Field.java?rev=1054227&r1=1054226&r2=1054227&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Field.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Field.java Sat Jan  1 12:24:25
2011
@@ -536,6 +536,9 @@ public abstract class Field extends Abst
             if (id.indexOf('>') != -1) {
                 id = id.replace('>', '_');
             }
+            if (id.indexOf('.') != -1) {
+                id = id.replace('.', '_');
+            }
 
             return id;
         }

Modified: click/trunk/click/framework/src/org/apache/click/control/Panel.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Panel.java?rev=1054227&r1=1054226&r2=1054227&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Panel.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Panel.java Sat Jan  1 12:24:25
2011
@@ -548,6 +548,9 @@ public class Panel extends AbstractConta
             if (id.indexOf('>') != -1) {
                 id = id.replace('>', '_');
             }
+            if (id.indexOf('.') != -1) {
+                id = id.replace('.', '_');
+            }
 
             return id;
         }

Modified: click/trunk/click/framework/src/org/apache/click/control/Radio.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Radio.java?rev=1054227&r1=1054226&r2=1054227&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Radio.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Radio.java Sat Jan  1 12:24:25
2011
@@ -160,6 +160,9 @@ public class Radio extends Field {
             if (id.indexOf('>') != -1) {
                 id = id.replace('>', '_');
             }
+            if (id.indexOf('.') != -1) {
+                id = id.replace('.', '_');
+            }
 
             return id;
         }



Mime
View raw message