click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r1037400 - in /click/trunk/click: build/ framework/src/org/apache/click/ajax/ framework/src/org/apache/click/control/
Date Sun, 21 Nov 2010 09:21:50 GMT
Author: sabob
Date: Sun Nov 21 09:21:49 2010
New Revision: 1037400

URL: http://svn.apache.org/viewvc?rev=1037400&view=rev
Log:
checkstyle

Modified:
    click/trunk/click/build/checkstyle-suppressions.xml
    click/trunk/click/framework/src/org/apache/click/ajax/DefaultAjaxBehavior.java
    click/trunk/click/framework/src/org/apache/click/control/AbstractControl.java
    click/trunk/click/framework/src/org/apache/click/control/FieldSet.java
    click/trunk/click/framework/src/org/apache/click/control/Form.java
    click/trunk/click/framework/src/org/apache/click/control/Table.java

Modified: click/trunk/click/build/checkstyle-suppressions.xml
URL: http://svn.apache.org/viewvc/click/trunk/click/build/checkstyle-suppressions.xml?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/build/checkstyle-suppressions.xml (original)
+++ click/trunk/click/build/checkstyle-suppressions.xml Sun Nov 21 09:21:49 2010
@@ -62,8 +62,8 @@
     <!-- Method Length -->
     <suppress checks="MethodLength" files="ErrorReport.java"  lines="186"/>
     <suppress checks="MethodLength" files="ClickServlet.java" lines="476"/>
-    <suppress checks="MethodLength" files="Form.java"         lines="2436"/>
-    <suppress checks="MethodLength" files="FieldSet.java"     lines="997"/>
+    <suppress checks="MethodLength" files="Form.java"         lines="2490"/>
+    <suppress checks="MethodLength" files="FieldSet.java"     lines="1097"/>
 
     <!-- Static Variable Name -->
     <suppress checks="StaticVariableName" files="MenuFactory.java"  lines="118,121"/>

Modified: click/trunk/click/framework/src/org/apache/click/ajax/DefaultAjaxBehavior.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/ajax/DefaultAjaxBehavior.java?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/ajax/DefaultAjaxBehavior.java (original)
+++ click/trunk/click/framework/src/org/apache/click/ajax/DefaultAjaxBehavior.java Sun Nov
21 09:21:49 2010
@@ -18,7 +18,6 @@
  */
 package org.apache.click.ajax;
 
-import org.apache.click.Behavior;
 import org.apache.click.Context;
 import org.apache.click.Control;
 import org.apache.click.ActionResult;
@@ -90,6 +89,11 @@ public class DefaultAjaxBehavior impleme
         headElementsProcessed = true;
     }
 
+    /**
+     * @see org.apache.click.Behavior#preDestroy(org.apache.click.Control)
+     *
+     * @param source the control the behavior is registered with
+     */
     public void preDestroy(Control source) {
         headElementsProcessed = false;
     }

Modified: click/trunk/click/framework/src/org/apache/click/control/AbstractControl.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/AbstractControl.java?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/AbstractControl.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/AbstractControl.java Sun Nov
21 09:21:49 2010
@@ -41,7 +41,6 @@ import org.apache.click.Context;
 import org.apache.click.Control;
 import org.apache.click.Page;
 import org.apache.click.element.Element;
-import org.apache.click.util.ActionListenerAdaptor;
 import org.apache.click.util.ClickUtils;
 import org.apache.click.util.HtmlStringBuffer;
 
@@ -215,7 +214,7 @@ public abstract class AbstractControl im
     /**
      * Return the control's action listener. If the control has a listener
      * target and listener method defined, this method will return an
-     * {@link ActionListenerAdaptor} instance.
+     * {@link org.apache.click.ActionListener} instance.
      *
      * @return the control's action listener
      */

Modified: click/trunk/click/framework/src/org/apache/click/control/FieldSet.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/FieldSet.java?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/FieldSet.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/FieldSet.java Sun Nov 21 09:21:49
2010
@@ -894,9 +894,9 @@ public class FieldSet extends Field impl
         List<Field> fields = new ArrayList<Field>();
         addStatefulFields(this, fields);
         Map<String, Object> stateMap = new HashMap<String, Object>();
-        for(Field field : fields) {
+        for (Field field : fields) {
             Object state = field.getState();
-            if(state != null) {
+            if (state != null) {
                 stateMap.put(field.getName(), state);
             }
         }
@@ -923,7 +923,7 @@ public class FieldSet extends Field impl
         List<Field> fields = new ArrayList<Field>();
         addStatefulFields(this, fields);
 
-        for(Field field : fields) {
+        for (Field field : fields) {
             String fieldName = field.getName();
             if (stateMap.containsKey(fieldName)) {
                 Object fieldState = stateMap.get(fieldName);

Modified: click/trunk/click/framework/src/org/apache/click/control/Form.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Form.java?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Form.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Form.java Sun Nov 21 09:21:49
2010
@@ -1220,7 +1220,8 @@ public class Form extends AbstractContai
     }
 
     /**
-     * Return the Form HTML HEAD elements for the following resources:
+     * Return the Form HEAD elements to be included in the page.
+     * The following resources are returned:
      *
      * <ul>
      * <li><tt>click/control.css</tt></li>
@@ -1879,9 +1880,9 @@ public class Form extends AbstractContai
         List<Field> fields = new ArrayList<Field>();
         addStatefulFields(this, fields);
         Map<String, Object> stateMap = new HashMap<String, Object>();
-        for(Field field : fields) {
+        for (Field field : fields) {
             Object state = field.getState();
-            if(state != null) {
+            if (state != null) {
                 stateMap.put(field.getName(), state);
             }
         }
@@ -1907,7 +1908,7 @@ public class Form extends AbstractContai
         List<Field> fields = new ArrayList<Field>();
         addStatefulFields(this, fields);
 
-        for(Field field : fields) {
+        for (Field field : fields) {
             String fieldName = field.getName();
             if (stateMap.containsKey(fieldName)) {
                 Object fieldState = stateMap.get(fieldName);

Modified: click/trunk/click/framework/src/org/apache/click/control/Table.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Table.java?rev=1037400&r1=1037399&r2=1037400&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Table.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Table.java Sun Nov 21 09:21:49
2010
@@ -387,7 +387,7 @@ public class Table extends AbstractContr
      */
     protected int bannerPosition = POSITION_BOTTOM;
 
-    /** The table HTML &lt;caption&gt; element */
+    /** The table HTML &lt;caption&gt; element. */
     protected String caption;
 
     /** The map of table columns keyed by column name. */



Mime
View raw message