click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bck...@apache.org
Subject svn commit: r986296 - /click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java
Date Tue, 17 Aug 2010 12:43:06 GMT
Author: bckfnn
Date: Tue Aug 17 12:43:06 2010
New Revision: 986296

URL: http://svn.apache.org/viewvc?rev=986296&view=rev
Log:
use Map.entrySet() for iteration. suggested by findbugs.

Modified:
    click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java

Modified: click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java?rev=986296&r1=986295&r2=986296&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java (original)
+++ click/trunk/click/framework/src/org/apache/click/util/ClickUtils.java Tue Aug 17 12:43:06
2010
@@ -488,12 +488,11 @@ public class ClickUtils {
         buffer.append("<form name=\"form\" method=\"post\" style=\"{display:none;}\" action=\"");
         buffer.append(target);
         buffer.append("\">");
-        for (Object name : params.keySet()) {
-            String value = params.get(name).toString();
+        for (Map.Entry<?, ?> entry : params.entrySet()) {
             buffer.elementStart("textarea");
-            buffer.appendAttribute("name", name);
+            buffer.appendAttribute("name", entry.getKey());
             buffer.elementEnd();
-            buffer.append(value);
+            buffer.append(entry.getValue());
             buffer.elementEnd("textarea");
         }
         buffer.append("</form></body></html>");



Mime
View raw message