click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bck...@apache.org
Subject svn commit: r986282 - in /click/trunk/click/framework/src/org/apache/click/util: MessagesMap.java PropertyUtils.java
Date Tue, 17 Aug 2010 11:59:35 GMT
Author: bckfnn
Date: Tue Aug 17 11:59:34 2010
New Revision: 986282

URL: http://svn.apache.org/viewvc?rev=986282&view=rev
Log:
improved equals() for cachekeys. suggested by findbugs.

Modified:
    click/trunk/click/framework/src/org/apache/click/util/MessagesMap.java
    click/trunk/click/framework/src/org/apache/click/util/PropertyUtils.java

Modified: click/trunk/click/framework/src/org/apache/click/util/MessagesMap.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/util/MessagesMap.java?rev=986282&r1=986281&r2=986282&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/util/MessagesMap.java (original)
+++ click/trunk/click/framework/src/org/apache/click/util/MessagesMap.java Tue Aug 17 11:59:34
2010
@@ -385,6 +385,9 @@ public class MessagesMap implements Map<
             if (this == o) {
                 return true;
             }
+            if (!(o instanceof CacheKey)) {
+                return false;
+            }
 
             CacheKey that = (CacheKey) o;
 

Modified: click/trunk/click/framework/src/org/apache/click/util/PropertyUtils.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/util/PropertyUtils.java?rev=986282&r1=986281&r2=986282&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/util/PropertyUtils.java (original)
+++ click/trunk/click/framework/src/org/apache/click/util/PropertyUtils.java Tue Aug 17 11:59:34
2010
@@ -280,6 +280,9 @@ public class PropertyUtils {
             if (this == o) {
                 return true;
             }
+            if (!(o instanceof CacheKey)) {
+                return false;
+            }
 
             CacheKey that = (CacheKey) o;
 



Mime
View raw message