click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bck...@apache.org
Subject svn commit: r986274 - in /click/trunk/click: framework/src/org/apache/click/control/Form.java mock/src/org/apache/click/servlet/MockRequest.java
Date Tue, 17 Aug 2010 11:50:23 GMT
Author: bckfnn
Date: Tue Aug 17 11:50:22 2010
New Revision: 986274

URL: http://svn.apache.org/viewvc?rev=986274&view=rev
Log:
make inner classes static. suggested by findbugs.

Modified:
    click/trunk/click/framework/src/org/apache/click/control/Form.java
    click/trunk/click/mock/src/org/apache/click/servlet/MockRequest.java

Modified: click/trunk/click/framework/src/org/apache/click/control/Form.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Form.java?rev=986274&r1=986273&r2=986274&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Form.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Form.java Tue Aug 17 11:50:22
2010
@@ -3003,7 +3003,7 @@ public class Form extends AbstractContai
     /**
      * Provides a HiddenField which does not bind to incoming values.
      */
-    private class NonbindableHiddenField extends HiddenField {
+    private static class NonbindableHiddenField extends HiddenField {
 
         private static final long serialVersionUID = 1L;
 
@@ -3042,7 +3042,7 @@ public class Form extends AbstractContai
      * Provides a HiddenField which name and value cannot be changed, once it
      * is set.
      */
-    private class ImmutableHiddenField extends HiddenField {
+    private static class ImmutableHiddenField extends HiddenField {
 
         private static final long serialVersionUID = 1L;
 

Modified: click/trunk/click/mock/src/org/apache/click/servlet/MockRequest.java
URL: http://svn.apache.org/viewvc/click/trunk/click/mock/src/org/apache/click/servlet/MockRequest.java?rev=986274&r1=986273&r2=986274&view=diff
==============================================================================
--- click/trunk/click/mock/src/org/apache/click/servlet/MockRequest.java (original)
+++ click/trunk/click/mock/src/org/apache/click/servlet/MockRequest.java Tue Aug 17 11:50:22
2010
@@ -1412,7 +1412,7 @@ public class MockRequest implements Http
      *
      * @author Frank Bille (billen)
      */
-    private class UploadedFile {
+    private static class UploadedFile {
 
         /** Name of the file field. */
         private String fieldName;



Mime
View raw message