click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r965159 - in /click/trunk/click/extras/src/org/apache/click/extras/control: AutoCompleteTextField.java DateField.java Menu.java
Date Sun, 18 Jul 2010 05:17:57 GMT
Author: sabob
Date: Sun Jul 18 05:17:56 2010
New Revision: 965159

URL: http://svn.apache.org/viewvc?rev=965159&view=rev
Log:
added explanation for code pattern

Modified:
    click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
    click/trunk/click/extras/src/org/apache/click/extras/control/DateField.java
    click/trunk/click/extras/src/org/apache/click/extras/control/Menu.java

Modified: click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java?rev=965159&r1=965158&r2=965159&view=diff
==============================================================================
--- click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
(original)
+++ click/trunk/click/extras/src/org/apache/click/extras/control/AutoCompleteTextField.java
Sun Jul 18 05:17:56 2010
@@ -326,6 +326,9 @@ public abstract class AutoCompleteTextFi
                 versionIndicator));
         }
 
+        // Note: the setup script is recreated and checked if it is contained in
+        // the headElement. This check cater for when the field is used by another
+        // Control using the fly-weight pattern eg. FormTable.
         String fieldId = getId();
         JsScript script = new JsScript();
         script.setId(fieldId + "-autocomplete");

Modified: click/trunk/click/extras/src/org/apache/click/extras/control/DateField.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/src/org/apache/click/extras/control/DateField.java?rev=965159&r1=965158&r2=965159&view=diff
==============================================================================
--- click/trunk/click/extras/src/org/apache/click/extras/control/DateField.java (original)
+++ click/trunk/click/extras/src/org/apache/click/extras/control/DateField.java Sun Jul 18
05:17:56 2010
@@ -877,9 +877,9 @@ public class DateField extends TextField
         JsScript script = new JsScript();
         script.setId(fieldId + "-js-setup");
 
-        // Note the Calendar options script is recreated and checked if it
-        // is contained in the headElement. This caters for when the field is
-        // used in a fly-weight pattern such as FormTable.
+        // Note: the setup script is recreated and checked if it is contained in
+        // the headElement. This check cater for when the field is used by another
+        // Control using the fly-weight pattern eg. FormTable.
         if (!headElements.contains(script)) {
 
             // Script must be executed as soon as browser dom is ready

Modified: click/trunk/click/extras/src/org/apache/click/extras/control/Menu.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/src/org/apache/click/extras/control/Menu.java?rev=965159&r1=965158&r2=965159&view=diff
==============================================================================
--- click/trunk/click/extras/src/org/apache/click/extras/control/Menu.java (original)
+++ click/trunk/click/extras/src/org/apache/click/extras/control/Menu.java Sun Jul 18 05:17:56
2010
@@ -1028,7 +1028,7 @@ public class Menu extends AbstractContro
      * <ul>
      * <li><tt>click/menu.css</tt></li>
      * <li><tt>click/control.js</tt></li>
-     * <li><tt>click/menu-fix-ie6.js</tt> (fixes menu burnthrough and hover
issues)</li>
+     * <li><tt>click/menu-fix-ie6.js</tt> (fixes IE6 menu burnthrough and
hover issues)</li>
      * </ul>
      *
      * @see org.apache.click.Control#getHeadElements()
@@ -1059,6 +1059,9 @@ public class Menu extends AbstractContro
             headElements.add(jsImport);
         }
 
+        // Note: the setup script is recreated and checked if it is contained in
+        // the headElement. This check cater for when the menu is used by another
+        // Control using the fly-weight pattern eg. FormTable.
         JsScript script = new JsScript();
         script.setId(id + "-js-setup");
         if (!headElements.contains(script)) {



Mime
View raw message