click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bck...@apache.org
Subject svn commit: r961617 - in /click/trunk/click/extras/test/org/apache/click/extras: control/ pages/ panel/
Date Thu, 08 Jul 2010 07:50:30 GMT
Author: bckfnn
Date: Thu Jul  8 07:50:29 2010
New Revision: 961617

URL: http://svn.apache.org/viewvc?rev=961617&view=rev
Log:
fix minor compile warnings.

Modified:
    click/trunk/click/extras/test/org/apache/click/extras/control/AbstractContainerFieldText.java
    click/trunk/click/extras/test/org/apache/click/extras/control/DateFieldTest.java
    click/trunk/click/extras/test/org/apache/click/extras/control/MenuTest.java
    click/trunk/click/extras/test/org/apache/click/extras/control/NumberFieldTest.java
    click/trunk/click/extras/test/org/apache/click/extras/pages/MemoryFileItemUploadPage.java
    click/trunk/click/extras/test/org/apache/click/extras/panel/TabbedPanelTest.java

Modified: click/trunk/click/extras/test/org/apache/click/extras/control/AbstractContainerFieldText.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/control/AbstractContainerFieldText.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/control/AbstractContainerFieldText.java
(original)
+++ click/trunk/click/extras/test/org/apache/click/extras/control/AbstractContainerFieldText.java
Thu Jul  8 07:50:29 2010
@@ -27,7 +27,6 @@ import org.apache.click.servlet.MockRequ
 import org.apache.click.servlet.MockResponse;
 import org.apache.click.servlet.MockServletConfig;
 import org.apache.click.servlet.MockServletContext;
-import org.apache.click.servlet.MockSession;
 
 public class AbstractContainerFieldText extends TestCase {
 
@@ -39,6 +38,9 @@ public class AbstractContainerFieldText 
         initMockContext();
 
         AbstractContainerField field = new AbstractContainerField() {
+            private static final long serialVersionUID = 1L;
+
+            @Override
             public String getTag() {
                 return "div";
             }
@@ -68,15 +70,14 @@ public class AbstractContainerFieldText 
     private void initMockContext() {
         MockServletContext servletContext = new MockServletContext();
         String servletName = "click-servlet";
-        String servletPath = "test";
         MockServletConfig servletConfig = new MockServletConfig(servletName,
             servletContext);
         ClickServlet servlet = new ClickServlet();
         MockResponse response = new MockResponse();
-        MockSession session = new MockSession(servletContext);
         MockRequest request = new MockRequest() {
 
             // Override getParameter to throw exception if argument is null
+            @Override
             public String getParameter(String name) {
                 if (name == null) {
                     throw new IllegalArgumentException("Null parameter");
@@ -88,7 +89,9 @@ public class AbstractContainerFieldText 
     }
     
     class FeedbackBorder extends AbstractContainerField {
+        private static final long serialVersionUID = 1L;
 
+        @Override
         public Control insert(Control control, int index) {
 
             // Enforce rule that only 1 control can be added

Modified: click/trunk/click/extras/test/org/apache/click/extras/control/DateFieldTest.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/control/DateFieldTest.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/control/DateFieldTest.java (original)
+++ click/trunk/click/extras/test/org/apache/click/extras/control/DateFieldTest.java Thu Jul
 8 07:50:29 2010
@@ -144,6 +144,8 @@ public class DateFieldTest extends TestC
     }
 
     public class MyDateField extends DateField {
+        private static final long serialVersionUID = 1L;
+
         public MyDateField(String name) {
             super(name);
         }

Modified: click/trunk/click/extras/test/org/apache/click/extras/control/MenuTest.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/control/MenuTest.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/control/MenuTest.java (original)
+++ click/trunk/click/extras/test/org/apache/click/extras/control/MenuTest.java Thu Jul  8
07:50:29 2010
@@ -58,6 +58,8 @@ public class MenuTest extends TestCase {
     }
 
     public class MyMenu extends Menu {
+        private static final long serialVersionUID = 1L;
+
         public MyMenu(String name) {
             super(name);
         }

Modified: click/trunk/click/extras/test/org/apache/click/extras/control/NumberFieldTest.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/control/NumberFieldTest.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/control/NumberFieldTest.java (original)
+++ click/trunk/click/extras/test/org/apache/click/extras/control/NumberFieldTest.java Thu
Jul  8 07:50:29 2010
@@ -43,8 +43,7 @@ public class NumberFieldTest extends Tes
     }
 
     public void testFormat() {
-        MockContext mockContext = MockContext.initContext(Locale.US);
-        MockRequest req = mockContext.getMockRequest();
+        MockContext.initContext(Locale.US);
         
         Number decNum = new Float(2.56f);
         
@@ -96,8 +95,7 @@ public class NumberFieldTest extends Tes
         engF.setValue("3456,134");
         assertEquals(3456.134f, engF.getNumber().floatValue(),0);
         
-        mockContext = MockContext.initContext(Locale.GERMANY);
-        req = mockContext.getMockRequest();
+        MockContext.initContext(Locale.GERMANY);
         
         NumberField germanF = new NumberField("de");
         

Modified: click/trunk/click/extras/test/org/apache/click/extras/pages/MemoryFileItemUploadPage.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/pages/MemoryFileItemUploadPage.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/pages/MemoryFileItemUploadPage.java
(original)
+++ click/trunk/click/extras/test/org/apache/click/extras/pages/MemoryFileItemUploadPage.java
Thu Jul  8 07:50:29 2010
@@ -27,9 +27,11 @@ import org.apache.click.control.TextFiel
  * A Google App Engine (GAE) file upload test page.
  */
 public class MemoryFileItemUploadPage extends Page {
+    private static final long serialVersionUID = 1L;
 
     private Form form = new Form("form");
 
+    @Override
     public void onInit() {
         addControl(form);
         form.add(new TextField("firstname"));

Modified: click/trunk/click/extras/test/org/apache/click/extras/panel/TabbedPanelTest.java
URL: http://svn.apache.org/viewvc/click/trunk/click/extras/test/org/apache/click/extras/panel/TabbedPanelTest.java?rev=961617&r1=961616&r2=961617&view=diff
==============================================================================
--- click/trunk/click/extras/test/org/apache/click/extras/panel/TabbedPanelTest.java (original)
+++ click/trunk/click/extras/test/org/apache/click/extras/panel/TabbedPanelTest.java Thu Jul
 8 07:50:29 2010
@@ -99,6 +99,8 @@ public class TabbedPanelTest extends Tes
         tabbedPanel.add(new Panel("panel2"));
 
         tabbedPanel.setTabListener(new ActionListener() {
+            private static final long serialVersionUID = 1L;
+
             public boolean onAction(Control source) {
                 return false;
             }
@@ -107,7 +109,7 @@ public class TabbedPanelTest extends Tes
         tabbedPanel.onInit();
         tabbedPanel.onProcess();
         // Simulate ClickServlet triggering all action events
-        boolean actionResult = context.fireActionEventsAndClearRegistry();
+        boolean actionResult = context.executeActionListeners();
 
         // If tab listener was triggered the actionResult should be false
         assertFalse(actionResult);



Mime
View raw message