click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r952558 - in /click/trunk/click/framework/src/org/apache/click/control: Select.java Table.java
Date Tue, 08 Jun 2010 07:35:59 GMT
Author: sabob
Date: Tue Jun  8 07:35:59 2010
New Revision: 952558

URL: http://svn.apache.org/viewvc?rev=952558&view=rev
Log:
Table and Select should pull data from DataProvider during onRender event. This improved exception
handling. CLK-684

Modified:
    click/trunk/click/framework/src/org/apache/click/control/Select.java
    click/trunk/click/framework/src/org/apache/click/control/Table.java

Modified: click/trunk/click/framework/src/org/apache/click/control/Select.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Select.java?rev=952558&r1=952557&r2=952558&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Select.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Select.java Tue Jun  8 07:35:59
2010
@@ -929,6 +929,17 @@ public class Select extends Field {
     }
 
     /**
+     * This method invokes {@link #getOptionList()} to ensure exceptions thrown
+     * while retrieving options will be handled by the error page.
+     *
+     * @see org.apache.click.Control#onRender()
+     */
+    @Override
+    public void onRender() {
+        getOptionList();
+    }
+
+    /**
      * @see AbstractControl#getControlSizeEst()
      *
      * @return the estimated rendered control size in characters

Modified: click/trunk/click/framework/src/org/apache/click/control/Table.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Table.java?rev=952558&r1=952557&r2=952558&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Table.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Table.java Tue Jun  8 07:35:59
2010
@@ -1342,7 +1342,8 @@ public class Table extends AbstractContr
     }
 
     /**
-     * Perform any pre rendering logic.
+     * This method invokes {@link #getRowList()} to ensure exceptions thrown
+     * while retrieving table rows will be handled by the error page.
      *
      * @see org.apache.click.Control#onRender()
      */
@@ -1353,6 +1354,7 @@ public class Table extends AbstractContr
             Control control = getControls().get(i);
             control.onRender();
         }
+        getRowList();
     }
 
     /**



Mime
View raw message