click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r940054 - /click/trunk/click/framework/src/org/apache/click/control/Field.java
Date Sat, 01 May 2010 15:10:58 GMT
Author: sabob
Date: Sat May  1 15:10:58 2010
New Revision: 940054

URL: http://svn.apache.org/viewvc?rev=940054&view=rev
Log:
cleanup

Modified:
    click/trunk/click/framework/src/org/apache/click/control/Field.java

Modified: click/trunk/click/framework/src/org/apache/click/control/Field.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Field.java?rev=940054&r1=940053&r2=940054&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Field.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Field.java Sat May  1 15:10:58
2010
@@ -181,11 +181,11 @@ import org.apache.click.util.HtmlStringB
  */
 public abstract class Field extends AbstractControl {
 
-    // -------------------------------------------------------------- Constants
+    // Constants --------------------------------------------------------------
 
     private static final long serialVersionUID = 1L;
 
-    // ----------------------------------------------------- Instance Variables
+    // Instance Variables -----------------------------------------------------
 
     /** The Field disabled value. */
     protected boolean disabled;
@@ -240,7 +240,7 @@ public abstract class Field extends Abst
     /** The Field value. */
     protected String value;
 
-    // ----------------------------------------------------------- Constructors
+    // Constructors -----------------------------------------------------------
 
     /**
      * Construct a new Field object.
@@ -268,7 +268,7 @@ public abstract class Field extends Abst
         setLabel(label);
     }
 
-    // ------------------------------------------------------ Public Attributes
+    // Public Attributes ------------------------------------------------------
 
     /**
      * Set the parent of the Field.
@@ -280,6 +280,7 @@ public abstract class Field extends Abst
      * @throws IllegalArgumentException if the given parent instance is
      * referencing <tt>this</tt> object: <tt>if (parent == this)</tt>
      */
+    @Override
     public void setParent(Object parent) {
         if (parent == this) {
             throw new IllegalArgumentException("Cannot set parent to itself");
@@ -505,6 +506,7 @@ public abstract class Field extends Abst
      *
      * @return HTML element identifier attribute "id" value
      */
+    @Override
     public String getId() {
         if (hasAttributes() && getAttributes().containsKey("id")) {
             return getAttribute("id");
@@ -720,6 +722,7 @@ public abstract class Field extends Abst
      * @param listener the listener object with the named method to invoke
      * @param method the name of the method to invoke
      */
+    @Override
     public void setListener(Object listener, String method) {
         super.setListener(listener, method);
     }
@@ -1014,7 +1017,7 @@ public abstract class Field extends Abst
         setStyle("width", value);
     }
 
-    // --------------------------------------------------------- Public Methods
+    // Public Methods ---------------------------------------------------------
 
     /**
      * This method binds the submitted request value to the Field's value.
@@ -1030,16 +1033,6 @@ public abstract class Field extends Abst
     }
 
     /**
-     * This method does nothing. Subclasses may override this method to perform
-     * additional initialization.
-     *
-     * @see org.apache.click.Control#onInit()
-     */
-    public void onInit() {
-        super.onInit();
-    }
-
-    /**
      * This method processes the page request returning true to continue
      * processing or false otherwise. The Field <tt>onProcess()</tt> method is
      * typically invoked by the Form <tt>onProcess()</tt> method when
@@ -1065,6 +1058,7 @@ public abstract class Field extends Abst
      *
      * @return true to continue Page event processing or false otherwise
      */
+    @Override
     public boolean onProcess() {
         if (isDisabled()) {
             Context context = getContext();
@@ -1101,7 +1095,7 @@ public abstract class Field extends Abst
     public void validate() {
     }
 
-    // ------------------------------------------------------ Protected Methods
+    // Protected Methods ------------------------------------------------------
 
     /**
      * Return a normalized label for display in error messages.
@@ -1225,12 +1219,12 @@ public abstract class Field extends Abst
      * @return the field's value from the request
      */
     protected String getRequestValue() {
-        String value = getContext().getRequestParameter(getName());
-        if (value != null) {
+        String requestValue = getContext().getRequestParameter(getName());
+        if (requestValue != null) {
             if (isTrim()) {
-                return value.trim();
+                return requestValue.trim();
             } else {
-                return value;
+                return requestValue;
             }
         } else {
             return "";



Mime
View raw message