click-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sa...@apache.org
Subject svn commit: r925134 - in /click/trunk/click/framework/src/org/apache/click/control: Button.java Submit.java
Date Fri, 19 Mar 2010 08:30:48 GMT
Author: sabob
Date: Fri Mar 19 08:30:47 2010
New Revision: 925134

URL: http://svn.apache.org/viewvc?rev=925134&view=rev
Log:
cleanup

Modified:
    click/trunk/click/framework/src/org/apache/click/control/Button.java
    click/trunk/click/framework/src/org/apache/click/control/Submit.java

Modified: click/trunk/click/framework/src/org/apache/click/control/Button.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Button.java?rev=925134&r1=925133&r2=925134&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Button.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Button.java Fri Mar 19 08:30:47
2010
@@ -58,11 +58,11 @@ import org.apache.click.util.HtmlStringB
  */
 public class Button extends Field {
 
-    // -------------------------------------------------------------- Constants
+    // Constants --------------------------------------------------------------
 
     private static final long serialVersionUID = 1L;
 
-    // ----------------------------------------------------------- Constructors
+    // Constructors -----------------------------------------------------------
 
     /**
      * Create a button with the given name.
@@ -93,7 +93,7 @@ public class Button extends Field {
     public Button() {
     }
 
-    // ------------------------------------------------------ Public Attributes
+    // Public Attributes ------------------------------------------------------
 
     /**
      * Return the button's html tag: <tt>input</tt>.
@@ -102,6 +102,7 @@ public class Button extends Field {
      *
      * @return this controls html tag
      */
+    @Override
     public String getTag() {
         return "input";
     }
@@ -137,7 +138,7 @@ public class Button extends Field {
         return "button";
     }
 
-    // -------------------------------------------------------- Public Methods
+    // Public Methods --------------------------------------------------------
 
     /**
      * Returns true, as buttons perform no server side logic.
@@ -146,6 +147,7 @@ public class Button extends Field {
      *
      * @return true
      */
+    @Override
     public boolean onProcess() {
         return true;
     }
@@ -155,6 +157,7 @@ public class Button extends Field {
      *
      * @return the estimated rendered control size in characters
      */
+    @Override
     public int getControlSizeEst() {
         return 40;
     }
@@ -167,6 +170,7 @@ public class Button extends Field {
      *
      * @param buffer the specified buffer to render the control's output to
      */
+    @Override
     public void render(HtmlStringBuffer buffer) {
         buffer.elementStart(getTag());
 

Modified: click/trunk/click/framework/src/org/apache/click/control/Submit.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Submit.java?rev=925134&r1=925133&r2=925134&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Submit.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Submit.java Fri Mar 19 08:30:47
2010
@@ -48,7 +48,7 @@ public class Submit extends Button {
     /** The button is clicked. */
     protected boolean clicked;
 
-    // ----------------------------------------------------------- Constructors
+    // Constructors -----------------------------------------------------------
 
     /**
      * Create a Submit button with the given name.
@@ -123,7 +123,7 @@ public class Submit extends Button {
         super();
     }
 
-    // ------------------------------------------------------ Public Attributes
+    // Public Attributes ------------------------------------------------------
 
 
     /**
@@ -133,9 +133,9 @@ public class Submit extends Button {
      * @return true if button will cancel JavaScript form validation
      */
     public boolean getCancelJavaScriptValidation() {
-        String value = getAttribute("onclick");
+        String attrValue = getAttribute("onclick");
 
-        return "form.onsubmit=null;".equals(value);
+        return "form.onsubmit=null;".equals(attrValue);
     }
 
     /**
@@ -166,16 +166,18 @@ public class Submit extends Button {
      *
      * @return the input type: '<tt>submit</tt>'
      */
+    @Override
     public String getType() {
         return "submit";
     }
 
-    // --------------------------------------------------------- Public Methods
+    // Public Methods ---------------------------------------------------------
 
     /**
      * Bind the request submission, setting the {@link Field#value} and
      * {@link #clicked} properties if defined.
      */
+    @Override
     public void bindRequestValue() {
         this.value = getContext().getRequestParameter(getName());
 
@@ -199,6 +201,7 @@ public class Submit extends Button {
      *
      * @return true to continue Page event processing or false otherwise
      */
+    @Override
     public boolean onProcess() {
         bindRequestValue();
 



Mime
View raw message