chukwa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Yang <eric...@gmail.com>
Subject Re: agent: doubt about sleeping condition in FileTailer.java
Date Fri, 14 Dec 2012 21:47:40 GMT
Yes, you are right.  Mind submitting a patch?

regards,
Eric

On Fri, Dec 14, 2012 at 12:16 PM, Luangsay Sourygna <luangsay@gmail.com>wrote:

> Hi,
>
> In the run() method we have:
>         if (timeToReadFiles < SAMPLE_PERIOD_MS || shouldISleep) {
>           Thread.sleep(SAMPLE_PERIOD_MS);
>
> If there is no more data to tail, we shall sleep 2 seconds. Fine.
>
> But:
> if we manage to tail files in less than 2 seconds, then we must wait 2
> seconds.
> Even if there is more data to tail???
>
> Seems like it is a bug and the real condition should be:
> (timeToReadFiles < SAMPLE_PERIOD_MS && shouldISleep).
>
> Makes sense?
>
> Sourygna
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message